Re: Status 1.2.0-pre3

From: Stanislav Ievlev <inger@altlinux.ru>
Subject: Re: Status 1.2.0-pre3
Date: Thu, 27 Dec 2001 17:52:24 +0200
Next Article (by Author): TCB vs. RSBAC Stanislav Ievlev
Previous Article (by Author): Re: Merry Christmas! Stanislav Ievlev
Top of Thread: Status 1.2.0-pre3 Amon Ott
Articles sorted by: [Date] [Author] [Subject]
This is a multi-part message in MIME format.
--------------040105010909080601020008
Content-Type: multipart/alternative;
 boundary="------------040604020305010400080407"


--------------040604020305010400080407
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Amon Ott wrote:

>On Friday, 21. December 2001 14:49, Stanislav Ievlev wrote:
>
>>Amon Ott wrote:
>>
>>>- Fix rklogd problem with 2.4 kernels and put back into tools package
>>>
>>What's the problem with rklogd. It works fine on Castle. Do you use a
>>latest version?
>>
>
>It eats up all CPU time on my test systems under 2.4.16. May be a bug in 
>rsbac_syslog() as well.
>
I know about this bug and wrote about it some time ago.
I'm sending this patch again (it's was in ALL Castle's kernels!!!)

Please see this patch again:


>
>
>Amon.
>--
>http://www.rsbac.org
>-
>To unsubscribe from the rsbac list, send a mail to
>majordomo@rsbac.org with
>unsubscribe rsbac
>as single line in the body.
>



--------------040604020305010400080407
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <title></title>
</head>
<body>
Amon Ott wrote:<br>
<blockquote type="cite" cite="mid:01122715164002.00869@marvin">
  <pre wrap="">On Friday, 21. December 2001 14:49, Stanislav Ievlev wrote:<br></pre>
  <blockquote type="cite">
    <pre wrap="">Amon Ott wrote:<br></pre>
    <blockquote type="cite">
      <pre wrap="">- Fix rklogd problem with 2.4 kernels and put back into tools package<br></pre>
      </blockquote>
      <pre wrap="">What's the problem with rklogd. It works fine on Castle. Do you use a<br>latest version?<br></pre>
      </blockquote>
      <pre wrap=""><!----><br>It eats up all CPU time on my test systems under 2.4.16. May be a bug in <br>rsbac_syslog() as well.</pre>
      </blockquote>
I know about this bug and wrote about it some time ago.<br>
I'm sending this patch again (it's was in ALL Castle's kernels!!!)<br>
      <br>
Please see this patch again:<br>
      <br>
      <br>
      <blockquote type="cite" cite="mid:01122715164002.00869@marvin">
        <pre wrap=""><br><br>Amon.<br>--<br><a class="moz-txt-link-freetext" href="http://www.rsbac.org">http://www.rsbac.org</a><br>-<br>To unsubscribe from the rsbac list, send a mail to<br><a class="moz-txt-link-abbreviated" href="mailto:majordomo@rsbac.org">majordomo@rsbac.org</a> with<br>unsubscribe rsbac<br>as single line in the body.<br></pre>
        </blockquote>
        <br>
        <br>
        </body>
        </html>

--------------040604020305010400080407--

--------------040105010909080601020008
Content-Type: text/plain;
 name="rsbac-log.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="rsbac-log.patch"

--- linux/rsbac/help/debug.c.orig	Fri Mar 23 17:49:03 2001
+++ linux/rsbac/help/debug.c	Fri Apr 27 17:15:24 2001
@@ -24,6 +24,10 @@
 #include <linux/module.h>
 #include <linux/console.h>
 
+/*new*/
+spinlock_t rsbac_log_lock = SPIN_LOCK_UNLOCKED;
+/*new*/
+
 /* Boolean debug switch for data structures */
 int  rsbac_debug_ds = 0;
 
@@ -620,6 +624,7 @@
 		error = verify_area(VERIFY_WRITE,buf,len);
 		if (error)
 			goto out;
+
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,3,0)
 		cli();
 		error = -ERESTARTSYS;
@@ -644,15 +649,22 @@
 		}
 		sti();
 #else
+		error=wait_event_interruptible(rlog_wait,rlog_size);
+		if (error)
+		    goto out;
 		i = 0;
+		spin_lock_irq(&rsbac_log_lock);
 		while (rlog_size && i < len) {
 			c = rlog_buf[log_start & RLOG_BUF_MASK];
 			log_start++;
 			rlog_size--;
+			spin_unlock_irq(&rsbac_log_lock);
 			__put_user(c,buf);
 			buf++;
 			i++;
+			spin_lock_irq(&rsbac_log_lock); 
 		}
+		spin_unlock_irq(&rsbac_log_lock);
 #endif
 		error = i;
 		break;

--------------040105010909080601020008--

-
To unsubscribe from the rsbac list, send a mail to
majordomo@rsbac.org with
unsubscribe rsbac
as single line in the body.
Go to Compuniverse LWGate Home Page.